Review Request: Fix build and a crash

Commit Hook null at kde.org
Sun Nov 11 12:44:14 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107272/#review21819
-----------------------------------------------------------


This review has been submitted with commit 57f014cd0da23deb1e84e602dd3850259fa15910 by Dan Vrátil to branch kde-telepathy-0.5.

- Commit Hook


On Nov. 10, 2012, 9:13 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107272/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 9:13 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fix build - after Daniele's changes in TpLQt4 buildsystem, "make" does not produce libtelepathy-logger-qt4.so anymore, only .a
> 
> Fix crash - just got a crash when searching in logs, because item->date in some result was NULL
> 
> 
> Diffs
> -----
> 
>   TelepathyLoggerQt4/CMakeLists.txt 1c47376 
>   TelepathyLoggerQt4/pending-search.cpp e4df41a 
> 
> Diff: http://git.reviewboard.kde.org/r/107272/diff/
> 
> 
> Testing
> -------
> 
> make install -> libtelepathy-logger-qt4.so installed
> tried searching - no crash (in TpLQt4)
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121111/3333264f/attachment.html>


More information about the KDE-Telepathy mailing list