Review Request: Allow different handling of history messages and actions in the filters

[David Edmundson]

> On Nov. 9, 2012, 11:06 p.m., Daniele Elmo Domenichelli wrote:
> > I spoke with David a few days ago, but he was not convinced about adding all these methods.
> > The alternative could be to have only one method + just some flag, or even better to add to KTp::Message an enum.
> > Then we just call always "AbstractMessageFilter::filterMessage(Message &message)" everywhere, and inside we can switch over the enum and process correctly.
> > 
> > But if we go in this direction, I suggest to remove the filter{Incoming,Outgoing}Message methods, that become useless.
> > 
> > Comments?

Agreed. 

If you look in one of the commits in the filters branch the "incoming/outgoing" become a flag, rendering my different methods useless.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107095/#review21744
-----------------------------------------------------------


On Oct. 30, 2012, 5:58 a.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107095/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2012, 5:58 a.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Lasath Fernando.
> 
> 
> Description
> -------
> 
> Filters on actions are not executed, this is bad (for example see: https://bugs.kde.org/show_bug.cgi?id=309149)
> Moreover it is impossible to execute a different filter for messages in the chat log, and this is also bad (for example see: https://bugs.kde.org/show_bug.cgi?id=309152)
> 
> This patch add a new set of methods to the Filters, in order to be able to filter actions and history.
> Moreover these methods are used in the text to speech plugin.
> 
> 
> This addresses bugs 309149 and 309152.
>     http://bugs.kde.org/show_bug.cgi?id=309149
>     http://bugs.kde.org/show_bug.cgi?id=309152
> 
> 
> Diffs
> -----
> 
>   lib/message-processor.cpp 44dc765e66f4e62b7b6425f053324b5e6fc4cedc 
>   lib/logmanager.cpp 35700c035409ca350f44ee6b0d82b10fe11fb9cd 
>   lib/message-processor.h c6183f688f7ec6f3306994dcc5564e3b8ea8d04f 
>   lib/abstract-message-filter.cpp 798d33d50dde71bc3ed01de18cf407e6e2acc8d9 
>   lib/chat-widget.cpp fb52ec2f00012a29a12fe4597175414b98c39cad 
>   filters/texttospeech/tts-filter.cpp 2df979e2b3b452e7e3de3fcff24edbd144e12bee 
>   lib/abstract-message-filter.h 2b159deb99f32483690ac9c4fb73a8f610063d99 
>   filters/texttospeech/tts-filter.h ab4f74e555b84e087c1d67b3e8e265c4b3af04f9 
> 
> Diff: http://git.reviewboard.kde.org/r/107095/diff/
> 
> 
> Testing
> -------
> 
> Used in text to speech plugin, works
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121109/2e10c536/attachment-0001.html>