<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107095/">http://git.reviewboard.kde.org/r/107095/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 9th, 2012, 11:06 p.m., <b>Daniele Elmo Domenichelli</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I spoke with David a few days ago, but he was not convinced about adding all these methods.
The alternative could be to have only one method + just some flag, or even better to add to KTp::Message an enum.
Then we just call always "AbstractMessageFilter::filterMessage(Message &message)" everywhere, and inside we can switch over the enum and process correctly.
But if we go in this direction, I suggest to remove the filter{Incoming,Outgoing}Message methods, that become useless.
Comments?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Agreed.
If you look in one of the commits in the filters branch the "incoming/outgoing" become a flag, rendering my different methods useless.</pre>
<br />
<p>- David</p>
<br />
<p>On October 30th, 2012, 5:58 a.m., Daniele Elmo Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy, David Edmundson and Lasath Fernando.</div>
<div>By Daniele Elmo Domenichelli.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2012, 5:58 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Filters on actions are not executed, this is bad (for example see: https://bugs.kde.org/show_bug.cgi?id=309149)
Moreover it is impossible to execute a different filter for messages in the chat log, and this is also bad (for example see: https://bugs.kde.org/show_bug.cgi?id=309152)
This patch add a new set of methods to the Filters, in order to be able to filter actions and history.
Moreover these methods are used in the text to speech plugin.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used in text to speech plugin, works</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=309149">309149</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=309152">309152</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/message-processor.cpp <span style="color: grey">(44dc765e66f4e62b7b6425f053324b5e6fc4cedc)</span></li>
<li>lib/logmanager.cpp <span style="color: grey">(35700c035409ca350f44ee6b0d82b10fe11fb9cd)</span></li>
<li>lib/message-processor.h <span style="color: grey">(c6183f688f7ec6f3306994dcc5564e3b8ea8d04f)</span></li>
<li>lib/abstract-message-filter.cpp <span style="color: grey">(798d33d50dde71bc3ed01de18cf407e6e2acc8d9)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(fb52ec2f00012a29a12fe4597175414b98c39cad)</span></li>
<li>filters/texttospeech/tts-filter.cpp <span style="color: grey">(2df979e2b3b452e7e3de3fcff24edbd144e12bee)</span></li>
<li>lib/abstract-message-filter.h <span style="color: grey">(2b159deb99f32483690ac9c4fb73a8f610063d99)</span></li>
<li>filters/texttospeech/tts-filter.h <span style="color: grey">(ab4f74e555b84e087c1d67b3e8e265c4b3af04f9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107095/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>