Review Request: Import Kopete logs when adding new account in KCM

[Daniele Elmo Domenichelli]

> On Nov. 9, 2012, 10:09 a.m., Daniele Elmo Domenichelli wrote:
> > src/kcm-telepathy-accounts.cpp, line 403
> > <http://git.reviewboard.kde.org/r/107246/diff/2/?file=94441#file94441line403>
> >
> >     What is the default value for warningContinueCancel? I don't want my logs deleted because I hit return twice instead of just one... and perhaps a dialogYesNo is more appropriate.
> >     
> >     Anyway 2 dialogs are redundant in my opinion, can we have just one with a "Delete logs" checkbox instead? Or 3 buttons "Delete Account", "Delete Account and Logs", "Cancel"
> 
> Dan Vrátil wrote:
>     Default focus is on "Cancel", so it's safe (that's ensured by the KMessageBox::Dangerous flag)

Ok, this is good... but still I think 2 dialogs to remove an account is too much...


- Daniele Elmo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107246/#review21684
-----------------------------------------------------------


On Nov. 9, 2012, 2 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107246/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2012, 2 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> When you add a new account in the KCM, it will search for corresponding Kopete logs and ask whether to import them (and eventually import them).
> 
> 
> Bonus points for me: when you remove an account, you will be prompted whether you want to remove logs as well.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b4248fb 
>   src/CMakeLists.txt ee82fd0 
>   src/kcm-telepathy-accounts.h 29629eb 
>   src/kcm-telepathy-accounts.cpp 6389a67 
> 
> Diff: http://git.reviewboard.kde.org/r/107246/diff/
> 
> 
> Testing
> -------
> 
> Added account I had on Kopete to KTp, got prompted whether to import logs, confirmed, logs imported.
> Removed account, got prompted whether to clear logs, confirmed, logs gone.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121109/a0d0d964/attachment-0001.html>