Review Request: Import Kopete logs when adding new account in KCM

Dan Vrátil dvratil at redhat.com
Fri Nov 9 14:00:13 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107246/
-----------------------------------------------------------

(Updated Nov. 9, 2012, 2 p.m.)


Review request for Telepathy.


Changes
-------

- Added "Remove conversations logs" checkbox to "Remove Account?" confirmation dialog, rather then popping another dialog after this.


Description
-------

When you add a new account in the KCM, it will search for corresponding Kopete logs and ask whether to import them (and eventually import them).


Bonus points for me: when you remove an account, you will be prompted whether you want to remove logs as well.


Diffs (updated)
-----

  CMakeLists.txt b4248fb 
  src/CMakeLists.txt ee82fd0 
  src/kcm-telepathy-accounts.h 29629eb 
  src/kcm-telepathy-accounts.cpp 6389a67 

Diff: http://git.reviewboard.kde.org/r/107246/diff/


Testing
-------

Added account I had on Kopete to KTp, got prompted whether to import logs, confirmed, logs imported.
Removed account, got prompted whether to clear logs, confirmed, logs gone.


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121109/684aef40/attachment.html>


More information about the KDE-Telepathy mailing list