Review Request: Kopete Logs Importer Implementation

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107243/
-----------------------------------------------------------

(Updated Nov. 9, 2012, 9:57 a.m.)


Review request for Telepathy.


Description
-------

This patch adds KTp::LogsImporter class to Common Internals.

You just need to pass Tp::AccountPtr to it and it will try to find a matching Kopete logs, convert them to TpLogger XML format and import them.

If the output log file already exists, the importer will simply skip it. I tried to implement merging but results were quite unpredictable. Most users won't have logs of conversations with the same contact from the same day from both Kopete AND KTp anyway.

The implementation supports AIM, WLM, ICQ, Yahoo, Jabber and GaduGadu protocols. I skipped Skype since we don't support it. Other protocols are not supported by Telepathy, so no reason to import them to TpLogger.

The class is places in common-internals, because it's used from KDED and KCM (I'll post separate reviews for these).


Diffs (updated)
-----

  KTp/CMakeLists.txt ae65dc7 
  KTp/logs-importer-private.h PRE-CREATION 
  KTp/logs-importer-private.cpp PRE-CREATION 
  KTp/logs-importer.h PRE-CREATION 
  KTp/logs-importer.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/107243/diff/


Testing
-------

Successfully imported my old Kopete logs and displayed them in LogViewer. However for testing purposes I recommend backuping ~/.local/share/TpLogger.


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121109/2feee147/attachment.html>