Review Request: Kopete Logs Importer Implementation

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107243/#review21604
-----------------------------------------------------------

Ship it!


Nice! Seriously awesome \o/



KTp/logs-importer-private.h
<http://git.reviewboard.kde.org/r/107243/#comment16781>

    make this const
    
    (or static)



KTp/logs-importer-private.cpp
<http://git.reviewboard.kde.org/r/107243/#comment16780>

    = false



KTp/logs-importer.h
<http://git.reviewboard.kde.org/r/107243/#comment16779>

    TpQt uses mPriv.
    
    but in our code we tend to use d to match KDELibs
    
    (though we need to work on making that consistent) 



KTp/logs-importer.cpp
<http://git.reviewboard.kde.org/r/107243/#comment16778>

    delete m_priv


- David Edmundson


On Nov. 7, 2012, 2:16 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107243/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2012, 2:16 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This patch adds KTp::LogsImporter class to Common Internals.
> 
> You just need to pass Tp::AccountPtr to it and it will try to find a matching Kopete logs, convert them to TpLogger XML format and import them.
> 
> If the output log file already exists, the importer will simply skip it. I tried to implement merging but results were quite unpredictable. Most users won't have logs of conversations with the same contact from the same day from both Kopete AND KTp anyway.
> 
> The implementation supports AIM, WLM, ICQ, Yahoo, Jabber and GaduGadu protocols. I skipped Skype since we don't support it. Other protocols are not supported by Telepathy, so no reason to import them to TpLogger.
> 
> The class is places in common-internals, because it's used from KDED and KCM (I'll post separate reviews for these).
> 
> 
> Diffs
> -----
> 
>   KTp/CMakeLists.txt ae65dc7 
>   KTp/logs-importer-private.h PRE-CREATION 
>   KTp/logs-importer-private.cpp PRE-CREATION 
>   KTp/logs-importer.h PRE-CREATION 
>   KTp/logs-importer.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107243/diff/
> 
> 
> Testing
> -------
> 
> Successfully imported my old Kopete logs and displayed them in LogViewer. However for testing purposes I recommend backuping ~/.local/share/TpLogger.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121108/e2ff737f/attachment.html>