Review Request: AccountsModel -> ContactsModel

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107186/#review21559
-----------------------------------------------------------

Ship it!



contact-list-widget.h
<http://git.reviewboard.kde.org/r/107186/#comment16751>

    Please rename the method as well. It does not return AccountsModel anymore.



contact-list-widget.cpp
<http://git.reviewboard.kde.org/r/107186/#comment16752>

    Absolute nitpicking - let's keep the comments up-to-date. AccountsModel -> ContactsModel :)


- Dan Vrátil


On Nov. 3, 2012, 7:19 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107186/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2012, 7:19 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Initial port of the contact list to renamed models.
> 
> More still needs doing here, but this compiles and works.
> 
> 
> Diffs
> -----
> 
>   main-widget.cpp dec831871f6034d985a63e6bc8a7843d74d5cb69 
>   tooltips/contacttooltip.cpp 738bd5dfedd660dcc9029f14a3d6464c3ee34d94 
>   tooltips/tooltipmanager.cpp 7c506d7f045f0f0ace22f8265755a6798aa8cd16 
>   context-menu.cpp fa192839b0b56391cfd3126457eca72fd1ce86d6 
>   contact-list-widget_p.h 5868c88c3a3adbec81153ed9ee26c70c96f4046f 
>   contact-overlays.cpp 8ea1b1ae53d0c5a26b2a92ca8f08157672ed447e 
>   contact-list-widget.cpp 6414dabe66aa4f9818595929aeb485d03dc3e43d 
>   contact-list-widget.h b3b4f7cc433bbb7b9556aa59e9222403451a7876 
>   contact-delegate.cpp 19ed1f028ff106dd6ca0788f432b2dfbc4de430e 
>   contact-delegate-compact.cpp 2cb00dcc5fad96a8c07d85475166f69e745d244d 
>   abstract-contact-delegate.cpp bc92109741e35abef53e9014d1f6019eeaf47e83 
> 
> Diff: http://git.reviewboard.kde.org/r/107186/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121107/295ab6a8/attachment-0001.html>