<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107186/">http://git.reviewboard.kde.org/r/107186/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107186/diff/1/?file=93373#file93373line45" style="color: black; font-weight: bold; text-decoration: underline;">contact-list-widget.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class ContactListWidget : public QTreeView</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">Accoun</span>tsModel</span> <span class="o">*</span><span class="n">accountsModel</span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">Contac</span>tsModel</span> <span class="o">*</span><span class="n">accountsModel</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please rename the method as well. It does not return AccountsModel anymore.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107186/diff/1/?file=93374#file93374line619" style="color: black; font-weight: bold; text-decoration: underline;">contact-list-widget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ContactListWidget::mouseMoveEvent(QMouseEvent *event)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">619</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">//We put a contact ID and its account ID to the stream, so we can later recreate the contact using AccountsModel</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">619</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">//We put a contact ID and its account ID to the stream, so we can later recreate the contact using AccountsModel</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Absolute nitpicking - let's keep the comments up-to-date. AccountsModel -> ContactsModel :)</pre>
</div>
<br />
<p>- Dan</p>
<br />
<p>On November 3rd, 2012, 7:19 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Nov. 3, 2012, 7:19 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Initial port of the contact list to renamed models.
More still needs doing here, but this compiles and works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>main-widget.cpp <span style="color: grey">(dec831871f6034d985a63e6bc8a7843d74d5cb69)</span></li>
<li>tooltips/contacttooltip.cpp <span style="color: grey">(738bd5dfedd660dcc9029f14a3d6464c3ee34d94)</span></li>
<li>tooltips/tooltipmanager.cpp <span style="color: grey">(7c506d7f045f0f0ace22f8265755a6798aa8cd16)</span></li>
<li>context-menu.cpp <span style="color: grey">(fa192839b0b56391cfd3126457eca72fd1ce86d6)</span></li>
<li>contact-list-widget_p.h <span style="color: grey">(5868c88c3a3adbec81153ed9ee26c70c96f4046f)</span></li>
<li>contact-overlays.cpp <span style="color: grey">(8ea1b1ae53d0c5a26b2a92ca8f08157672ed447e)</span></li>
<li>contact-list-widget.cpp <span style="color: grey">(6414dabe66aa4f9818595929aeb485d03dc3e43d)</span></li>
<li>contact-list-widget.h <span style="color: grey">(b3b4f7cc433bbb7b9556aa59e9222403451a7876)</span></li>
<li>contact-delegate.cpp <span style="color: grey">(19ed1f028ff106dd6ca0788f432b2dfbc4de430e)</span></li>
<li>contact-delegate-compact.cpp <span style="color: grey">(2cb00dcc5fad96a8c07d85475166f69e745d244d)</span></li>
<li>abstract-contact-delegate.cpp <span style="color: grey">(bc92109741e35abef53e9014d1f6019eeaf47e83)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107186/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>