Review Request: Paint the icon properly

[Martin Klapetek]

> On May 24, 2012, 9:32 a.m., Andrea Scarpino wrote:
> > Works great.
> 
> Martin Klapetek wrote:
>     Except opening the contact list by clicking the icon does not work at all. We need to figure this out before shipping, otherwise we have a regression here.
> 
> Andrea Scarpino wrote:
>     Oh, I tought that was intentional because the icon tray doesn't open the contactlist neither :)

You have to set it to do so in the plasmoid settings, but it works. And I can't figure out why this patch breaks it (but then again, I'm no plasma expert).


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104675/#review14115
-----------------------------------------------------------


On April 19, 2012, 7:48 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104675/
> -----------------------------------------------------------
> 
> (Updated April 19, 2012, 7:48 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This fixes the bug when the plasmoid in panel is invisible. It also adds some padding, so it looks nicer in the panel.
> 
> However the click action on the applet suddenly stopped working. No idea why, all seems correct. I'm putting it up so we can try figuring it out.
> 
> 
> Diffs
> -----
> 
>   plasma_applet_ktp_presence.desktop 283a3f9 
>   src/presenceapplet.h 4f1a2d5 
>   src/presenceapplet.cpp de3ae5c 
> 
> Diff: http://git.reviewboard.kde.org/r/104675/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120524/108a358f/attachment.html>