Review Request: Add static methods to retrieve icon, iconName and displaystring from a Tp::ConnectionPresenceType to KTp presence

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Fri Mar 30 14:17:32 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104069/#review12019
-----------------------------------------------------------


I'm discarding this because I discussed with David and we decided to drop it, because you can always use Tp::Presence instead of Tp::ConnectionPresenceType.
If anyone wants to say something in favour of this patch please speak now

- Daniele Elmo Domenichelli


On Feb. 24, 2012, 6:01 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104069/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2012, 6:01 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add static methods to retrieve icon, iconName and displaystring from a Tp::ConnectionPresenceType to KTp presence and use them internally
> 
> 
> Diffs
> -----
> 
>   KTp/presence.h d116530c318586ef290f7193c9f1956f4e47b77d 
>   KTp/presence.cpp 35bc0dc6088b875bf719a22f45938184b1f96bb2 
> 
> Diff: http://git.reviewboard.kde.org/r/104069/diff/
> 
> 
> Testing
> -------
> 
> Built, installed, and run components using them.
> Everything seems ok.
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120330/3f271fc5/attachment.html>


More information about the KDE-Telepathy mailing list