Review Request: Block/Unblock feature in ktp-text-ui module.

Ahmed Ibrahim ahmedibrahimkhali at
Thu Mar 29 23:46:58 UTC 2012

This is an automatically generated e-mail. To reply, visit:

(Updated March 29, 2012, 11:46 p.m.)

Review request for Telepathy and Daniele Elmo Domenichelli.


Removed the onUnblockOperationFinished and onBlockOperationFinished and now I depend on the contactBlockStatusChanged signal that comes from the ChannelContactModel.


Added Block/Unblock contact button to the KActionCollection of the ktp-text-ui.
Added also code that will help in displaying blocking/unblocking actions to the user in the ChatView.

This addresses bug 292402.

Diffs (updated)

  app/chat-window.h 8ee4463 
  app/chat-window.cpp 75dd968 
  app/chatwindow.rc f65fbd1 
  app/main.cpp d76ce04 
  lib/channel-contact-model.h 41d5d84 
  lib/channel-contact-model.cpp d731322 
  lib/chat-widget.h e1efbbb 
  lib/chat-widget.cpp bb1f5ef 



Blocked a contact and found that is blocked in another IM client and had other opened tabs and the button was changing according to the user's block state 


Ahmed Ibrahim

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDE-Telepathy mailing list