Review Request: Block/Unblock feature in ktp-text-ui module.
Daniele Elmo Domenichelli
daniele.domenichelli at gmail.com
Wed Mar 28 01:19:51 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104407/#review11934
-----------------------------------------------------------
The patch looks ok, but I think you are not connecting the toolbar item from the changes from the outside (i.e. if I block a person from the contact list the toolbar button will still show the block button)
app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104407/#comment9456>
extra space
lib/channel-contact-model.cpp
<http://git.reviewboard.kde.org/r/104407/#comment9455>
Please remove some of this extra space
lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/104407/#comment9457>
What would you like to add here? A message like "You banned foo" or "You unbanned foo"? Do it then! :D
- Daniele Elmo Domenichelli
On March 26, 2012, 9:58 a.m., Ahmed Ibrahim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104407/
> -----------------------------------------------------------
>
> (Updated March 26, 2012, 9:58 a.m.)
>
>
> Review request for Telepathy and Daniele Elmo Domenichelli.
>
>
> Description
> -------
>
> Added Block/Unblock contact button to the KActionCollection of the ktp-text-ui.
> Added also code that will help in displaying blocking/unblocking actions to the user in the ChatView.
>
>
> This addresses bug 292402.
> http://bugs.kde.org/show_bug.cgi?id=292402
>
>
> Diffs
> -----
>
> app/chat-window.h 8ee4463
> app/chat-window.cpp 75dd968
> app/chatwindow.rc f65fbd1
> app/main.cpp d76ce04
> lib/channel-contact-model.h 41d5d84
> lib/channel-contact-model.cpp d731322
> lib/chat-widget.h e1efbbb
> lib/chat-widget.cpp bb1f5ef
>
> Diff: http://git.reviewboard.kde.org/r/104407/diff/
>
>
> Testing
> -------
>
> Blocked a contact and found that is blocked in another IM client and had other opened tabs and the button was changing according to the user's block state
>
>
> Thanks,
>
> Ahmed Ibrahim
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120328/35a99e21/attachment-0001.html>
More information about the KDE-Telepathy
mailing list