Review Request: Make the 'Now listening..' presence string configurable

[Othmane Moustaouda]

> On March 17, 2012, 2:57 p.m., David Edmundson wrote:
> > telepathy-mpris.cpp, line 182
> > <http://git.reviewboard.kde.org/r/104314/diff/1/?file=53621#file53621line182>
> >
> >     Should we load up default text?
> >     
> >     I think currently there's potential for this config value to not exist on first load, at which point presence message changes to "".
> >     I suggest, just like in the the config module:
> >     
> >     kdedConfig.readEntry(QLatin1String("nowPlayingText"),
> >                                               i18nc("The text displayed by now playing plugin", "Now listening to %title by %author from album %album"));
> >

I had not thought about this, I'll change it!


- Othmane


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104314/#review11505
-----------------------------------------------------------


On March 17, 2012, 2:29 p.m., Othmane Moustaouda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104314/
> -----------------------------------------------------------
> 
> (Updated March 17, 2012, 2:29 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Enabled the possibility for the user to set his custom 'Now listening' presence string
> 
> 
> This addresses bug 282944.
>     http://bugs.kde.org/show_bug.cgi?id=282944
> 
> 
> Diffs
> -----
> 
>   config/telepathy-kded-config.cpp 1fb515f56500407b7b221d1d5310237f8d94ca7f 
>   telepathy-mpris.h d909863e68d0fdc7a6eb4ebb972d975ba224b6ef 
>   telepathy-mpris.cpp 8dae701a203f6c5ba43a622ce7125615b4392b63 
> 
> Diff: http://git.reviewboard.kde.org/r/104314/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Othmane Moustaouda
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120319/205cc5a1/attachment.html>