Review Request: Make the 'Now listening..' presence string configurable

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104314/#review11505
-----------------------------------------------------------


Very nice first patch.

There's a bit of an i18n issue, I'd like someone else to comment on this. 


telepathy-mpris.cpp
<http://git.reviewboard.kde.org/r/104314/#comment9151>

    Not sure QLatin1String is right.
    
    Lets say we're Italian.
    
    The default text will have been translated to:
    "Ora l'ascolto di %titolo per %autore da %albumino"
    
    At which point this will do nothing.
    
    If we do use i18n here, it will need to be an i18nc where we explain in the comment exactly that these strings need to match the default text used elsewhere.



telepathy-mpris.cpp
<http://git.reviewboard.kde.org/r/104314/#comment9150>

    Should we load up default text?
    
    I think currently there's potential for this config value to not exist on first load, at which point presence message changes to "".
    I suggest, just like in the the config module:
    
    kdedConfig.readEntry(QLatin1String("nowPlayingText"),
                                              i18nc("The text displayed by now playing plugin", "Now listening to %title by %author from album %album"));
    


- David Edmundson


On March 17, 2012, 2:29 p.m., Othmane Moustaouda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104314/
> -----------------------------------------------------------
> 
> (Updated March 17, 2012, 2:29 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Enabled the possibility for the user to set his custom 'Now listening' presence string
> 
> 
> This addresses bug 282944.
>     http://bugs.kde.org/show_bug.cgi?id=282944
> 
> 
> Diffs
> -----
> 
>   config/telepathy-kded-config.cpp 1fb515f56500407b7b221d1d5310237f8d94ca7f 
>   telepathy-mpris.h d909863e68d0fdc7a6eb4ebb972d975ba224b6ef 
>   telepathy-mpris.cpp 8dae701a203f6c5ba43a622ce7125615b4392b63 
> 
> Diff: http://git.reviewboard.kde.org/r/104314/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Othmane Moustaouda
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120317/a31ac075/attachment.html>