Review Request: Only show valid options in contact context menu
Alex Fiestas
alex at eyeos.org
Mon Jun 25 10:35:01 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105344/#review15107
-----------------------------------------------------------
Can't tell what this patch does exactly (screenshots !) but generally across all KDE software people usually grey out entries instead of removing them.
Maybe until there is a new standard ktp should do the same?
- Alex Fiestas
On June 24, 2012, 11:14 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105344/
> -----------------------------------------------------------
>
> (Updated June 24, 2012, 11:14 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Check if contact manager supports blocking contact before adding the item.
> Also only show re-request/resend authentication if it actually is a valid option.
>
>
> Diffs
> -----
>
> context-menu.cpp 988f321
> dialogs/remove-contact-dialog.cpp 7b5fa1f
>
> Diff: http://git.reviewboard.kde.org/r/105344/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120625/5869ddf0/attachment.html>
More information about the KDE-Telepathy
mailing list