Review Request: Only show valid options in contact context menu

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105344/#review15094
-----------------------------------------------------------


I'm not giving you the ship it since I'm not the maintainer nor a senior dev for the contact list :P
Anyway the patch looks good...


context-menu.cpp
<http://git.reviewboard.kde.org/r/105344/#comment11865>

    I think that this is done automatically, so you don't really need to do this check... Anyway it's not an issue.



context-menu.cpp
<http://git.reviewboard.kde.org/r/105344/#comment11866>

    Same


- Daniele Elmo Domenichelli


On June 24, 2012, 11:14 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105344/
> -----------------------------------------------------------
> 
> (Updated June 24, 2012, 11:14 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Check if contact manager supports blocking contact before adding the item.
> Also only show re-request/resend authentication if it actually is a valid option.
> 
> 
> Diffs
> -----
> 
>   context-menu.cpp 988f321 
>   dialogs/remove-contact-dialog.cpp 7b5fa1f 
> 
> Diff: http://git.reviewboard.kde.org/r/105344/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120625/e3164463/attachment.html>