Review Request: Image Plugin

[Lasath Fernando]

> On June 21, 2012, 5:36 p.m., Daniele Elmo Domenichelli wrote:
> > filters/images/images-filter.cpp, line 55
> > <http://git.reviewboard.kde.org/r/105313/diff/1/?file=70001#file70001line55>
> >
> >     isEmpty()

http://api.kde.org/4.8-api/kdelibs-apidocs/kdecore/html/classKUrl.html#a5c906aec0264fc5f8d0fae7a7b92a1d5

"Null if there is no file (and thus no path)."
I thought that meant I was supposed to check if null. (Unless I'm misinterpreting it).


> On June 21, 2012, 5:36 p.m., Daniele Elmo Domenichelli wrote:
> > lib/message-processor.cpp, line 54
> > <http://git.reviewboard.kde.org/r/105313/diff/1/?file=70003#file70003line54>
> >
> >     Can we have some method to set dependencies for a module or some mandatory flag instead of this?

There will be soon (eventually ;-).

David and I planned to store some sort of integer priority in the service file that would determine each plugin's position in the queue. 


> On June 21, 2012, 5:36 p.m., Daniele Elmo Domenichelli wrote:
> > filters/images/images-filter.cpp, line 50
> > <http://git.reviewboard.kde.org/r/105313/diff/1/?file=70001#file70001line50>
> >
> >     const QVariant &var

fixed.


- Lasath


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105313/#review14962
-----------------------------------------------------------


On June 23, 2012, 1:53 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105313/
> -----------------------------------------------------------
> 
> (Updated June 23, 2012, 1:53 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This is a plugin to Embed Images directly into a chat. (I pretty much rewrote the old code from scratch because I realized I wasn't very happy with it).
> 
> I've also bumped the version number of all the plugins. 
> 
> This diff depends on diff of the previous review (which I still haven't merged yet). I'll merge them both once this gets reviewed. 
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt PRE-CREATION 
>   filters/emoticons/ktptextui_message_filter_emoticons.desktop PRE-CREATION 
>   filters/escape/ktptextui_message_filter_escape.desktop PRE-CREATION 
>   filters/formatting/format-filter.cpp PRE-CREATION 
>   filters/formatting/ktptextui_message_filter_formatting.desktop PRE-CREATION 
>   filters/images/CMakeLists.txt PRE-CREATION 
>   filters/images/images-filter.h PRE-CREATION 
>   filters/images/images-filter.cpp PRE-CREATION 
>   filters/images/ktptextui_message_filter_images.desktop PRE-CREATION 
>   lib/message-processor.cpp a9b409e 
>   tests/message-processor-basic-tests.h PRE-CREATION 
>   tests/message-processor-basic-tests.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105313/diff/
> 
> 
> Testing
> -------
> 
> Passed Unit tests, saw memes in chat. 
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120623/6d6a3ca9/attachment-0001.html>