Review Request: Image Plugin

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105313/#review14962
-----------------------------------------------------------


A couple of minor issues...


filters/images/images-filter.cpp
<http://git.reviewboard.kde.org/r/105313/#comment11758>

    const QVariant &var



filters/images/images-filter.cpp
<http://git.reviewboard.kde.org/r/105313/#comment11759>

    isEmpty()



lib/message-processor.cpp
<http://git.reviewboard.kde.org/r/105313/#comment11760>

    Can we have some method to set dependencies for a module or some mandatory flag instead of this?


- Daniele Elmo Domenichelli


On June 21, 2012, 4:43 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105313/
> -----------------------------------------------------------
> 
> (Updated June 21, 2012, 4:43 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This is a plugin to Embed Images directly into a chat. (I pretty much rewrote the old code from scratch because I realized I wasn't very happy with it).
> 
> I've also bumped the version number of all the plugins. 
> 
> This diff depends on diff of the previous review (which I still haven't merged yet). I'll merge them both once this gets reviewed. 
> 
> 
> Diffs
> -----
> 
>   filters/images/ktptextui_message_filter_images.desktop PRE-CREATION 
>   lib/message-processor.cpp a9b409e 
>   filters/images/images-filter.cpp PRE-CREATION 
>   filters/escape/ktptextui_message_filter_escape.desktop PRE-CREATION 
>   filters/formatting/format-filter.cpp PRE-CREATION 
>   filters/formatting/ktptextui_message_filter_formatting.desktop PRE-CREATION 
>   filters/images/CMakeLists.txt PRE-CREATION 
>   filters/images/images-filter.h PRE-CREATION 
>   filters/CMakeLists.txt PRE-CREATION 
>   filters/emoticons/ktptextui_message_filter_emoticons.desktop PRE-CREATION 
>   tests/message-processor-basic-tests.h PRE-CREATION 
>   tests/message-processor-basic-tests.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105313/diff/
> 
> 
> Testing
> -------
> 
> Passed Unit tests, saw memes in chat. 
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120621/c9994a9e/attachment-0001.html>