Review Request: Image Plugin
Lasath Fernando
kde at lasath.org
Thu Jun 21 04:43:52 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105313/
-----------------------------------------------------------
Review request for Telepathy.
Description
-------
This is a plugin to Embed Images directly into a chat. (I pretty much rewrote the old code from scratch because I realized I wasn't very happy with it).
I've also bumped the version number of all the plugins.
This diff depends on diff of the previous review (which I still haven't merged yet). I'll merge them both once this gets reviewed.
Diffs
-----
filters/images/ktptextui_message_filter_images.desktop PRE-CREATION
lib/message-processor.cpp a9b409e
filters/images/images-filter.cpp PRE-CREATION
filters/escape/ktptextui_message_filter_escape.desktop PRE-CREATION
filters/formatting/format-filter.cpp PRE-CREATION
filters/formatting/ktptextui_message_filter_formatting.desktop PRE-CREATION
filters/images/CMakeLists.txt PRE-CREATION
filters/images/images-filter.h PRE-CREATION
filters/CMakeLists.txt PRE-CREATION
filters/emoticons/ktptextui_message_filter_emoticons.desktop PRE-CREATION
tests/message-processor-basic-tests.h PRE-CREATION
tests/message-processor-basic-tests.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/105313/diff/
Testing
-------
Passed Unit tests, saw memes in chat.
Thanks,
Lasath Fernando
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120621/7dea9add/attachment.html>
More information about the KDE-Telepathy
mailing list