Review Request: Small fixes in AbstractAccountParametersWidget to make rakia advanced options work properly

George Kiagiadakis kiagiadakis.george at gmail.com
Mon Jun 11 12:51:28 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105220/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Some fixes to make the rakia advanced options widget work properly...

commit 32c6caf33392bbafd0ad10e1e4d0ed45ac6645d5
Author: George Kiagiadakis <george.kiagiadakis at collabora.com>
Date:   Mon Jun 11 13:55:44 2012 +0300

    AbstractAccountParametersWidget: Reset parameters with disabled widgets to their default values when submitting changes

commit 2c2f47bdad9e55a45da2fae15e3f33c3f199caa8
Author: George Kiagiadakis <george.kiagiadakis at collabora.com>
Date:   Mon Jun 11 13:41:33 2012 +0300

    AbstractAccountParametersWidget: Remove unused variable

commit 42e919326ee0e3ecb2f0815f42bc28fb7925bc78
Author: George Kiagiadakis <george.kiagiadakis at collabora.com>
Date:   Mon Jun 11 13:30:56 2012 +0300

    AbstractAccountParametersWidget: Map the "currentText" property of QComboBox if the parameter requires a string type


Diffs
-----

  src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp b61e836b77809819a0f6f24f9b9b1bfe2a3af6a6 

Diff: http://git.reviewboard.kde.org/r/105220/diff/


Testing
-------

Tested setting/unsetting some properties and verifying with qdbus o.f.T.AccountManager ... that the stored parameters are correct (unlike before).


Thanks,

George Kiagiadakis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120611/b9ebb448/attachment.html>


More information about the KDE-Telepathy mailing list