Review Request: Create KCM to enable/disable MessageFilters

[George Kiagiadakis]

On July 14, 2012, 1:20 p.m., Lasath Fernando wrote:
> > You also need to adjust config/Messages.sh
> 
> Lasath Fernando wrote:
>     What do you mean?
>     
>     On that note, what does Messages.sh even do?

Messages.sh is part of kde's translation system. There is a bot called "scripty" running on some kde server that every now and then goes through all the repositories & folders in kde's git and svn and runs any Messages.sh scripts that it finds. These Messages.sh scripts then generate the .pot files that are the source for the translators, they contain all the untranslated strings together with their comments and their location in the code. Afterwards, scripty commits those .pot files in svn in a place where translators can see what new there is to translate. Clearly, if you don't have a Messages.sh for your code, then there are no translations as well.

In this case, we do one .pot file per kcm, so since you are adding a new kcm, you also need to adjust Messages.sh to generate "kcm_ktp_chat_messages.pot" from its source code.


- George


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105571/#review15844
-----------------------------------------------------------


On July 14, 2012, 2:55 p.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105571/
> -----------------------------------------------------------
> 
> (Updated July 14, 2012, 2:55 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> I skimmed through BKO and I don't think there are any bugs about not being able to disable Message Filters :O
> But anyway, this addresses that issue by building a KCM. There currently isn't any way of getting to it apart
> from running kcmshell4 kcm_ktp_chat_messages (which only now occurred to me might be an issue). 
> 
> When having to deal with only loading enabled plugins, the code in MessageProcessor started to get a little 
> horrific, so I split that off into a new class called PluginConfigManager. 
> 
> 
> Diffs
> -----
> 
>   app/chat-window.cpp 42d1672 
>   config/CMakeLists.txt dbe0de9 
>   config/kcm_ktp_chat_messages.desktop PRE-CREATION 
>   config/messages-config.h PRE-CREATION 
>   config/messages-config.cpp PRE-CREATION 
>   filters/emoticons/ktptextui_message_filter_emoticons.desktop 2626102 
>   filters/formatting/format-filter.cpp b8f0b53 
>   filters/formatting/ktptextui_message_filter_formatting.desktop 7dc8cb7 
>   filters/images/ktptextui_message_filter_images.desktop 649f206 
>   lib/CMakeLists.txt f172936 
>   lib/message-processor.h 08cc386 
>   lib/message-processor.cpp 926bef7 
>   lib/plugin-config-manager.h PRE-CREATION 
>   lib/plugin-config-manager.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105571/diff/
> 
> 
> Testing
> -------
> 
> Passes unit tests when plugins are enabled, fails when they're not.
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120718/3aafa941/attachment-0001.html>