Review Request: Create KCM to enable/disable MessageFilters

[Lasath Fernando]

> On July 14, 2012, 1:20 p.m., George Kiagiadakis wrote:
> > config/messages-config.cpp, line 31
> > <http://git.reviewboard.kde.org/r/105571/diff/1/?file=72661#file72661line31>
> >
> >     I have no fucking idea why, atm, but at least for consistency, the first string here should be "ktp_chat_messages"

Wow... someone blew a fuse ;-)
Fixed.


> On July 14, 2012, 1:20 p.m., George Kiagiadakis wrote:
> > lib/message-processor.cpp, line 32
> > <http://git.reviewboard.kde.org/r/105571/diff/1/?file=72668#file72668line32>
> >
> >     Are you actually using this somewhere?

Nope. forgot it when removing the code that used it.
Nice catch.


> On July 14, 2012, 1:20 p.m., George Kiagiadakis wrote:
> > lib/plugin-config-manager.cpp, lines 39-47
> > <http://git.reviewboard.kde.org/r/105571/diff/1/?file=72670#file72670line39>
> >
> >     You are checking twice for !pcm_instance

I copy-pasted from the singleton in MessageProcessor which, according to git credit, was written by David.

Fixed them both.


On July 14, 2012, 1:20 p.m., Lasath Fernando wrote:
> > You also need to adjust config/Messages.sh

What do you mean?

On that note, what does Messages.sh even do?


- Lasath


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105571/#review15844
-----------------------------------------------------------


On July 14, 2012, 12:36 p.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105571/
> -----------------------------------------------------------
> 
> (Updated July 14, 2012, 12:36 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> I skimmed through BKO and I don't think there are any bugs about not being able to disable Message Filters :O
> But anyway, this addresses that issue by building a KCM. There currently isn't any way of getting to it apart
> from running kcmshell4 kcm_ktp_chat_messages (which only now occurred to me might be an issue). 
> 
> When having to deal with only loading enabled plugins, the code in MessageProcessor started to get a little 
> horrific, so I split that off into a new class called PluginConfigManager. 
> 
> 
> Diffs
> -----
> 
>   lib/plugin-config-manager.h PRE-CREATION 
>   lib/plugin-config-manager.cpp PRE-CREATION 
>   config/messages-config.cpp PRE-CREATION 
>   filters/emoticons/ktptextui_message_filter_emoticons.desktop 2626102 
>   filters/formatting/format-filter.cpp b8f0b53 
>   filters/formatting/ktptextui_message_filter_formatting.desktop 7dc8cb7 
>   filters/images/ktptextui_message_filter_images.desktop 649f206 
>   lib/CMakeLists.txt f172936 
>   lib/message-processor.h 08cc386 
>   lib/message-processor.cpp 926bef7 
>   config/kcm_ktp_chat_messages.desktop PRE-CREATION 
>   config/messages-config.h PRE-CREATION 
>   config/CMakeLists.txt dbe0de9 
> 
> Diff: http://git.reviewboard.kde.org/r/105571/diff/
> 
> 
> Testing
> -------
> 
> Passes unit tests when plugins are enabled, fails when they're not.
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120714/5db2159f/attachment-0001.html>