Review Request: QuickChat Plasmoid: Annoying weird button is annoying

[Lasath Fernando]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105542/#review15951
-----------------------------------------------------------

Ship it!


If no-one has any objections regarding the ordering of buttons, that's a Ship It from me.


plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml
<http://git.reviewboard.kde.org/r/105542/#comment12576>

    Trailing Whitespace...



plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml
<http://git.reviewboard.kde.org/r/105542/#comment12575>

    Trailing Whitespace...


- Lasath Fernando


On July 16, 2012, 2:23 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105542/
> -----------------------------------------------------------
> 
> (Updated July 16, 2012, 2:23 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Make the minimize button a separate button.
> Put all the top buttons in a toolbar.
> 
> 
> This addresses bug 293488.
>     http://bugs.kde.org/show_bug.cgi?id=293488
> 
> 
> Diffs
> -----
> 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml 90cc07d 
> 
> Diff: http://git.reviewboard.kde.org/r/105542/diff/
> 
> 
> Testing
> -------
> 
> I talked to myself wisely.
> 
> 
> Screenshots
> -----------
> 
> After
>   http://git.reviewboard.kde.org/r/105542/s/636/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120716/5f8b5e02/attachment-0001.html>