Review Request: QuickChat Plasmoid: Annoying weird button is annoying

Aleix Pol Gonzalez aleixpol at gmail.com
Mon Jul 16 02:23:43 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105542/
-----------------------------------------------------------

(Updated July 16, 2012, 2:23 a.m.)


Review request for Telepathy and David Edmundson.


Changes
-------

New version of the patch without the change to a toolbar.

I still think toolbar should be used, but I understand there are issues to be fixed in the plasma components first.

Hope this helps.


Description
-------

Make the minimize button a separate button.
Put all the top buttons in a toolbar.


This addresses bug 293488.
    http://bugs.kde.org/show_bug.cgi?id=293488


Diffs (updated)
-----

  plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml 90cc07d 

Diff: http://git.reviewboard.kde.org/r/105542/diff/


Testing
-------

I talked to myself wisely.


Screenshots
-----------

After
  http://git.reviewboard.kde.org/r/105542/s/636/


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120716/be021c71/attachment.html>


More information about the KDE-Telepathy mailing list