Review Request: Show the 'phone' client type in contact list

[Martin Klapetek]

> On July 15, 2012, 4:23 p.m., Martin Klapetek wrote:
> > Screenshot: Full List
> > <http://git.reviewboard.kde.org>
> >
> >     One tiny nitpick - the padding on the left side is bigger than the one on the right, if you could make the one on the right smaller in one go (both delegates), that would be perfect.
> 
> Dominik Cermak wrote:
>     Because the spacings changed a bit I added new screenshots. If this is still the case on them can you please mark the place in the screenshot as I didn't really understood what you mean.
> 
> Martin Klapetek wrote:
>     Look at the space between the presence icon and the right window border and then look at the blue pawn and the left window border. But I think this was like that before. Looking more closely I see more spacing issues, so I'd say commit this patch and then we can take a look at the paddings separately. We also need to take the font size into account in sizeHint().
>     
>     tl;dr - ship it, we'll fix it in another patch
> 
> Dominik Cermak wrote:
>     Look at shot 5 (the padding for the avatar is the same everywhere) there you can see for 'Matti' and 'Sascha' that the padding is the same as for the presence icon, it's both 4 px :)

Ah, so it's actually just the pawn icon that causes that, cool :)

The other spacings I had in mind are the name string, which is too high, but that's again the pawn, with avatars it looks considerably better. I still think we can put it few pixels down, to be closer to the presence message, another is the spacing in the compact one between avatar and the contact name (look at the latest compact screenshot), but that seems again just the pawn having too much empty space.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105514/#review15891
-----------------------------------------------------------


On July 15, 2012, 5:43 p.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105514/
> -----------------------------------------------------------
> 
> (Updated July 15, 2012, 5:43 p.m.)
> 
> 
> Review request for Telepathy and KDE Usability.
> 
> 
> Description
> -------
> 
> This shows a phone icon left of the presence icon for contacts that are online with a phone.
> Currently it only shows the client type of 'phone' (other possible are: bot, console, handheld, pc, web), because I think this is the most important. Also interesting could be 'web'.
> 
> The usability group is added for comments/discussion about the place where to put the icon. What do you think about it?
> 
> 
> This addresses bug 302963.
>     http://bugs.kde.org/show_bug.cgi?id=302963
> 
> 
> Diffs
> -----
> 
>   contact-delegate-compact.cpp 91f3497bac5585d922d1d6c071e3ec6b8796daa1 
>   contact-delegate.cpp 2b8a86398340d9b11e05e9928f9c64f396ce8e00 
>   main-widget.cpp ac4fd415cee72bb0d450a0bb2205f58d9e94e3d7 
> 
> Diff: http://git.reviewboard.kde.org/r/105514/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Full List
>   http://git.reviewboard.kde.org/r/105514/s/621/
> Compact List
>   http://git.reviewboard.kde.org/r/105514/s/622/
> Version where the icon moved to the left
>   http://git.reviewboard.kde.org/r/105514/s/623/
> Presence moved to the left
>   http://git.reviewboard.kde.org/r/105514/s/624/
> Avatar Overlay
>   http://git.reviewboard.kde.org/r/105514/s/625/
> Presence overlay
>   http://git.reviewboard.kde.org/r/105514/s/626/
> Latest
>   http://git.reviewboard.kde.org/r/105514/s/638/
> Latest compact
>   http://git.reviewboard.kde.org/r/105514/s/639/
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120715/a40612a1/attachment.html>