<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105514/">http://git.reviewboard.kde.org/r/105514/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 15th, 2012, 4:23 p.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td><a href="http://git.reviewboard.kde.org/r/105514/s/621/" style="color: black; font-weight: bold; font-size: 9pt;">clienttype.png</a></td>
</tr>
<tr>
<td><a href="http://git.reviewboard.kde.org/r/105514/s/621/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/11/clienttype_41_174_299_41.png" style="border: 1px black solid;" alt="Full List"></a></td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One tiny nitpick - the padding on the left side is bigger than the one on the right, if you could make the one on the right smaller in one go (both delegates), that would be perfect.</pre>
</blockquote>
<p>On July 15th, 2012, 5:44 p.m., <b>Dominik Cermak</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Because the spacings changed a bit I added new screenshots. If this is still the case on them can you please mark the place in the screenshot as I didn't really understood what you mean.</pre>
</blockquote>
<p>On July 15th, 2012, 8:06 p.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Look at the space between the presence icon and the right window border and then look at the blue pawn and the left window border. But I think this was like that before. Looking more closely I see more spacing issues, so I'd say commit this patch and then we can take a look at the paddings separately. We also need to take the font size into account in sizeHint().
tl;dr - ship it, we'll fix it in another patch</pre>
</blockquote>
<p>On July 15th, 2012, 8:16 p.m., <b>Dominik Cermak</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Look at shot 5 (the padding for the avatar is the same everywhere) there you can see for 'Matti' and 'Sascha' that the padding is the same as for the presence icon, it's both 4 px :)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, so it's actually just the pawn icon that causes that, cool :)
The other spacings I had in mind are the name string, which is too high, but that's again the pawn, with avatars it looks considerably better. I still think we can put it few pixels down, to be closer to the presence message, another is the spacing in the compact one between avatar and the contact name (look at the latest compact screenshot), but that seems again just the pawn having too much empty space.</pre>
<br />
<p>- Martin</p>
<br />
<p>On July 15th, 2012, 5:43 p.m., Dominik Cermak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and KDE Usability.</div>
<div>By Dominik Cermak.</div>
<p style="color: grey;"><i>Updated July 15, 2012, 5:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This shows a phone icon left of the presence icon for contacts that are online with a phone.
Currently it only shows the client type of 'phone' (other possible are: bot, console, handheld, pc, web), because I think this is the most important. Also interesting could be 'web'.
The usability group is added for comments/discussion about the place where to put the icon. What do you think about it?</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=302963">302963</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>contact-delegate-compact.cpp <span style="color: grey">(91f3497bac5585d922d1d6c071e3ec6b8796daa1)</span></li>
<li>contact-delegate.cpp <span style="color: grey">(2b8a86398340d9b11e05e9928f9c64f396ce8e00)</span></li>
<li>main-widget.cpp <span style="color: grey">(ac4fd415cee72bb0d450a0bb2205f58d9e94e3d7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105514/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105514/s/621/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/11/clienttype_400x100.png" style="border: 1px black solid;" alt="Full List" /></a>
<a href="http://git.reviewboard.kde.org/r/105514/s/622/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/11/clienttype_compact_400x100.png" style="border: 1px black solid;" alt="Compact List" /></a>
<a href="http://git.reviewboard.kde.org/r/105514/s/623/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/11/clienttype_compact_left_400x100.png" style="border: 1px black solid;" alt="Version where the icon moved to the left" /></a>
<a href="http://git.reviewboard.kde.org/r/105514/s/624/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/11/clienttype_compact_presence_left_400x100.png" style="border: 1px black solid;" alt="Presence moved to the left" /></a>
<a href="http://git.reviewboard.kde.org/r/105514/s/625/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/11/clienttype_compact_avatar_overlay_400x100.png" style="border: 1px black solid;" alt="Avatar Overlay" /></a>
<a href="http://git.reviewboard.kde.org/r/105514/s/626/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/11/clienttype_compact_presence_overlay_400x100.png" style="border: 1px black solid;" alt="Presence overlay" /></a>
<a href="http://git.reviewboard.kde.org/r/105514/s/638/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/15/clienttypefinal_400x100.png" style="border: 1px black solid;" alt="Latest" /></a>
<a href="http://git.reviewboard.kde.org/r/105514/s/639/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/15/clienttypefinal_compact_400x100.png" style="border: 1px black solid;" alt="Latest compact" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>