Review Request: Models: Check for Call1 capabilities and also export capabilities for accounts

David Edmundson kde at davidedmundson.co.uk
Sat Jul 14 13:43:50 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105572/#review15846
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On July 14, 2012, 12:37 p.m., George Kiagiadakis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105572/
> -----------------------------------------------------------
> 
> (Updated July 14, 2012, 12:37 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> - Removed calls to the deprecated streamedMedia-related functions and replaced them with the equivalent Call1 ones.
> - Implemented capability filtering on accounts (useful for ktp-dialout-ui to show only accounts that support calls).
> - Fixed a typo in accounts-filter-model.cpp
> - Added a hack to workaround gabble's bug https://bugs.freedesktop.org/show_bug.cgi?id=51978
> 
> 
> Diffs
> -----
> 
>   KTp/Models/capabilities-hack-private.cpp PRE-CREATION 
>   KTp/Models/capabilities-hack-private.h PRE-CREATION 
>   KTp/Models/accounts-model-item.cpp b85e9e3bfbe16a8096413236ee3fb5842a857f3b 
>   KTp/Models/CMakeLists.txt 7c8d93db5bda62054682ca9bf83a941fc907209b 
>   KTp/Models/accounts-filter-model.cpp bd8eaa48dd41e621451e804328c43233bf83f04d 
>   KTp/Models/contact-model-item.cpp 6778504b226e00b41b76c1e1b511c73c9388f6b8 
> 
> Diff: http://git.reviewboard.kde.org/r/105572/diff/
> 
> 
> Testing
> -------
> 
> tested with CL and ktp-dialout-ui
> 
> 
> Thanks,
> 
> George Kiagiadakis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120714/a86f7fa7/attachment.html>


More information about the KDE-Telepathy mailing list