Review Request: QuickChat Plasmoid: remove loop dependencies in visible state

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105543/
-----------------------------------------------------------

(Updated July 14, 2012, 1:19 a.m.)


Review request for Telepathy and David Edmundson.


Changes
-------

Addressed the issues commented by Lasath


Description
-------

This patch (tries?) to fix a problem we've been experiencing where the dialog might not be shown properly.
I identified the root of the problem in the usage of the button's checked property that would do weird things when triggering a checked change from onClicked because the click itself would change the state, so it's messy.

I changed it to be a normal button with an "activeChat" property that shows a "speaking" icon when true for visual feedback on what's the active chat. This way we can make the plasmoid to track the visible dialog exclusively with the currentIndex.

I think it works better than it used to.


This addresses bug 302440.
    http://bugs.kde.org/show_bug.cgi?id=302440


Diffs (updated)
-----

  plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegate.qml f3729a0 
  plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml 5f73e4b 

Diff: http://git.reviewboard.kde.org/r/105543/diff/


Testing
-------

I talked to myself multiple times, in parallel.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120714/627cff37/attachment.html>