Review Request: QuickChat Plasmoid: remove loop dependencies in visible state

[Lasath Fernando]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105543/#review15766
-----------------------------------------------------------


Ah Kudos for actually fixing the giant clusterfuck that was putting up the popup. I kept meaning to make a 'proper' fix for it (probably using states) with an ETA approaching Valve-Time, but now I don't need to :D


plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegate.qml
<http://git.reviewboard.kde.org/r/105543/#comment12302>

    trailing whitespace



plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegate.qml
<http://git.reviewboard.kde.org/r/105543/#comment12297>

    This might be better off as the highlight of the ListView than being in the delegate itself.
    
    http://qt-project.org/doc/qt-4.8/qml-listview.html#highlight-prop



plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/105543/#comment12301>

    This no longer closes the popup when it's already open. 
    
    I think it's an important feature, because users would expect this button to be a toggle (like Plasma's PopupApplet).



plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/105543/#comment12300>

    This should be set to convButton.chatActive, to avoid duplicating logic.
    
    I think it makes more sense since the Dialog shouldn't need to know why it's in the active delegate - just that it is.


- Lasath Fernando


On July 13, 2012, 1:52 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105543/
> -----------------------------------------------------------
> 
> (Updated July 13, 2012, 1:52 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> This patch (tries?) to fix a problem we've been experiencing where the dialog might not be shown properly.
> I identified the root of the problem in the usage of the button's checked property that would do weird things when triggering a checked change from onClicked because the click itself would change the state, so it's messy.
> 
> I changed it to be a normal button with an "activeChat" property that shows a "speaking" icon when true for visual feedback on what's the active chat. This way we can make the plasmoid to track the visible dialog exclusively with the currentIndex.
> 
> I think it works better than it used to.
> 
> 
> This addresses bug 302440.
>     http://bugs.kde.org/show_bug.cgi?id=302440
> 
> 
> Diffs
> -----
> 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegate.qml f3729a0 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml 5f73e4b 
> 
> Diff: http://git.reviewboard.kde.org/r/105543/diff/
> 
> 
> Testing
> -------
> 
> I talked to myself multiple times, in parallel.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120713/b09016cb/attachment-0001.html>