Review Request: Few improvements in LogViewer

[Dan Vratil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105450/
-----------------------------------------------------------

(Updated July 9, 2012, 3:13 p.m.)


Review request for Telepathy.


Changes
-------

Fixed coding style issues, d_ed's missing reference ;) and removed the redundant registerTypes(). I moved the LogViewer::clearMainView() method to AdiumThereViewer::clear() rather then ChatWidget to make it easily accessible for everyone (might get useful one day...).

Regarding the model - yes, the EntityModelItem acts as an Account or Entity/Contact, depending on Role (it's similar to what KTp::ContactModel does, right?). Also I prefer using pointers in models, but if you would insist, I can change it :)


Description
-------

- display entities as a per-account tree view
- try to display contact's real name (or nickname) if possible. This does not work when account is offline (we need active connection), in such case it falls back to TelepathyLoggerQt4::Entity::alias()
- use QSplitter to make width of the EntityView and MessageView adjustable
- make the window slightly bigger by default


Diffs (updated)
-----

  lib/adium-theme-view.h 747a8ef 
  lib/adium-theme-view.cpp a97ba98 
  logviewer/CMakeLists.txt bb22191 
  logviewer/entity-model-item.h PRE-CREATION 
  logviewer/entity-model-item.cpp PRE-CREATION 
  logviewer/entity-model.h cd6649e 
  logviewer/entity-model.cpp a661d10 
  logviewer/entity-proxy-model.h PRE-CREATION 
  logviewer/entity-proxy-model.cpp PRE-CREATION 
  logviewer/entity-view.h 03c23d1 
  logviewer/entity-view.cpp 1ef5ef4 
  logviewer/log-viewer.cpp 2b472fa 
  logviewer/log-viewer.ui c5e6a09 

Diff: http://git.reviewboard.kde.org/r/105450/diff/


Testing
-------


Thanks,

Dan Vratil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120709/2f6f21d2/attachment.html>