<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105450/">http://git.reviewboard.kde.org/r/105450/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vratil.</div>
<p style="color: grey;"><i>Updated July 9, 2012, 3:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed coding style issues, d_ed's missing reference ;) and removed the redundant registerTypes(). I moved the LogViewer::clearMainView() method to AdiumThereViewer::clear() rather then ChatWidget to make it easily accessible for everyone (might get useful one day...).
Regarding the model - yes, the EntityModelItem acts as an Account or Entity/Contact, depending on Role (it's similar to what KTp::ContactModel does, right?). Also I prefer using pointers in models, but if you would insist, I can change it :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- display entities as a per-account tree view
- try to display contact's real name (or nickname) if possible. This does not work when account is offline (we need active connection), in such case it falls back to TelepathyLoggerQt4::Entity::alias()
- use QSplitter to make width of the EntityView and MessageView adjustable
- make the window slightly bigger by default</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/adium-theme-view.h <span style="color: grey">(747a8ef)</span></li>
<li>lib/adium-theme-view.cpp <span style="color: grey">(a97ba98)</span></li>
<li>logviewer/CMakeLists.txt <span style="color: grey">(bb22191)</span></li>
<li>logviewer/entity-model-item.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>logviewer/entity-model-item.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>logviewer/entity-model.h <span style="color: grey">(cd6649e)</span></li>
<li>logviewer/entity-model.cpp <span style="color: grey">(a661d10)</span></li>
<li>logviewer/entity-proxy-model.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>logviewer/entity-proxy-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>logviewer/entity-view.h <span style="color: grey">(03c23d1)</span></li>
<li>logviewer/entity-view.cpp <span style="color: grey">(1ef5ef4)</span></li>
<li>logviewer/log-viewer.cpp <span style="color: grey">(2b472fa)</span></li>
<li>logviewer/log-viewer.ui <span style="color: grey">(c5e6a09)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105450/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>