Review Request: Fix the runner applet to work with a newer version of Telepathy/KTp

[Dan Vratil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105398/
-----------------------------------------------------------

(Updated July 1, 2012, 11:09 a.m.)


Review request for Telepathy.


Changes
-------

I'm sorry, it somehow didn't occur to me that the bug could actually be in the runner :)

This patch does as you suggested - it throws away use of Match::id() and stores AccountsModelItem and ContactModelItem in Match::data() so that it can be retrieved quickly.


Description
-------

Since some (git) version of KTp or TelepathyQt (hard to say) the Accounts returned from AccountsModel have "ktp_contacts_" prefix in their ID but accountItemForId() fails to lookup the account with such prefix. Removing the prefix before passing the ID to accountItemForId() fixes the problem.

This fix does not affect older versions of Telepathy (where accounts don't have the prefix in ID), it just works by default there.

I guess this should be actually fixed in the AccountsModel (or wherever the problem comes from), but I briefly checked the code and haven't seen any obvious reason for this behavior, so I leave it up to you guys :-)


This addresses bug 302176.
    http://bugs.kde.org/show_bug.cgi?id=302176


Diffs (updated)
-----

  src/contactrunner.cpp db39190 

Diff: http://git.reviewboard.kde.org/r/105398/diff/


Testing
-------

Successfully reproduced the bug, with this patch it works again.


Thanks,

Dan Vratil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120701/6252d576/attachment-0001.html>