Review Request: Fix the runner applet to work with a newer version of Telepathy/KTp

[David Edmundson]

> On July 1, 2012, 9:09 a.m., David Edmundson wrote:
> > src/contactrunner.cpp, line 115
> > <http://git.reviewboard.kde.org/r/105398/diff/1/?file=70882#file70882line115>
> >
> >     So what's happened is two commits ago George K changed the krunner name for 0.4. 9073c837eed34cd230401106dff1d088a37c0483
> >     
> >     This broke it. 
> >     
> >     All we actually need to do in this patch 
> >     is change KRunnerKTpContacts_ to ktp_contacts.
> >

Edit: Use runner->name() to avoid having this in future.

Edit 2 better still: use match.data() instead of match.id() for doing this and you won't have this problem. (would also allow you to store a Tp::ContactPtr in the data()) which might be easier still rather than dealing with strings. Other runners use this.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105398/#review15283
-----------------------------------------------------------


On July 1, 2012, 8:05 a.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105398/
> -----------------------------------------------------------
> 
> (Updated July 1, 2012, 8:05 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Since some (git) version of KTp or TelepathyQt (hard to say) the Accounts returned from AccountsModel have "ktp_contacts_" prefix in their ID but accountItemForId() fails to lookup the account with such prefix. Removing the prefix before passing the ID to accountItemForId() fixes the problem.
> 
> This fix does not affect older versions of Telepathy (where accounts don't have the prefix in ID), it just works by default there.
> 
> I guess this should be actually fixed in the AccountsModel (or wherever the problem comes from), but I briefly checked the code and haven't seen any obvious reason for this behavior, so I leave it up to you guys :-)
> 
> 
> This addresses bug 302176.
>     http://bugs.kde.org/show_bug.cgi?id=302176
> 
> 
> Diffs
> -----
> 
>   src/contactrunner.h c316aa4 
>   src/contactrunner.cpp db39190 
> 
> Diff: http://git.reviewboard.kde.org/r/105398/diff/
> 
> 
> Testing
> -------
> 
> Successfully reproduced the bug, with this patch it works again.
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120701/8772495f/attachment.html>