Review Request: Add support for showing available rooms
Dominik Cermak
d.cermak at arcor.de
Mon Jan 30 17:16:39 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103825/
-----------------------------------------------------------
(Updated Jan. 30, 2012, 5:16 p.m.)
Review request for Telepathy.
Changes
-------
More coding style.
Show notification additionally to console debug output
ClickMessage for server lineedit.
Description
-------
This adds support for showing available rooms. You can query the default server of the selected account or specify a server yourself.
The list shows if the room is password protected, how many persons are there, the name and the description.
Suggestions for a better design are welcome.
Maybe make the labels of the first to lineedits also a clickMessage?
This addresses bug 291711.
http://bugs.kde.org/show_bug.cgi?id=291711
Diffs (updated)
-----
CMakeLists.txt e57d3895981c0d2b5a6f35e3e4265fca86e4ec28
dialogs/join-chat-room-dialog.h d0aba22bba3f271294bcaeae4b0e2527d200ac87
dialogs/join-chat-room-dialog.cpp 164f910aa7d06bab3ca3f7d9d472aa6d2d5ed09f
dialogs/join-chat-room-dialog.ui 6c64151b629139a69e21b85b09c7c57498f2cd8a
rooms-model.h PRE-CREATION
rooms-model.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103825/diff/diff
Testing
-------
Tested with XMPP.
Screenshots (updated)
-----------
Dialog with roomlist
http://git.reviewboard.kde.org/r/103825/s/422/
New version with ClickMessage in server linedit
http://git.reviewboard.kde.org/r/103825/s/424/
Thanks,
Dominik Cermak
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120130/47025a0a/attachment.html>
More information about the KDE-Telepathy
mailing list