Review Request: Add support for showing available rooms

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103825/#review10226
-----------------------------------------------------------

Ship it!


Great, just few small code-style nitpicks ;)


dialogs/join-chat-room-dialog.cpp
<http://git.reviewboard.kde.org/r/103825/#comment8416>

    * align



dialogs/join-chat-room-dialog.cpp
<http://git.reviewboard.kde.org/r/103825/#comment8417>

    * align



dialogs/join-chat-room-dialog.cpp
<http://git.reviewboard.kde.org/r/103825/#comment8418>

    If you expect any sensible errors here that might be helpful to the user, it would be worthy to show desktop notification instead. 



dialogs/join-chat-room-dialog.cpp
<http://git.reviewboard.kde.org/r/103825/#comment8419>

    Same as above



dialogs/join-chat-room-dialog.cpp
<http://git.reviewboard.kde.org/r/103825/#comment8420>

    Here too



dialogs/join-chat-room-dialog.ui
<http://git.reviewboard.kde.org/r/103825/#comment8415>

    Can we set the "leave blank..." (even modified) as the lineedit's clickmessage? Makes more sense to be there imho



rooms-model.cpp
<http://git.reviewboard.kde.org/r/103825/#comment8412>

    '*' goes right, in front of the variable ;)



rooms-model.cpp
<http://git.reviewboard.kde.org/r/103825/#comment8411>

    Same as with '*', '&' goes in front of the variable
    
    (also check the code below including header, I won't mark them all separately)



rooms-model.cpp
<http://git.reviewboard.kde.org/r/103825/#comment8413>

    Don't forget to remove the commented lines down below (but leave this comment here).



rooms-model.cpp
<http://git.reviewboard.kde.org/r/103825/#comment8414>

    I think here should be '> 0', because otherwise 'm_roomInfoList.size() - 1' could end up rather badly.


- Martin Klapetek


On Jan. 29, 2012, 9:15 p.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103825/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2012, 9:15 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This adds support for showing available rooms. You can query the default server of the selected account or specify a server yourself.
> The list shows if the room is password protected, how many persons are there, the name and the description.
> 
> Suggestions for a better design are welcome.
> Maybe make the labels of the first to lineedits also a clickMessage?
> 
> 
> This addresses bug 291711.
>     http://bugs.kde.org/show_bug.cgi?id=291711
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e57d3895981c0d2b5a6f35e3e4265fca86e4ec28 
>   dialogs/join-chat-room-dialog.h d0aba22bba3f271294bcaeae4b0e2527d200ac87 
>   dialogs/join-chat-room-dialog.cpp 164f910aa7d06bab3ca3f7d9d472aa6d2d5ed09f 
>   dialogs/join-chat-room-dialog.ui 6c64151b629139a69e21b85b09c7c57498f2cd8a 
>   rooms-model.h PRE-CREATION 
>   rooms-model.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103825/diff/diff
> 
> 
> Testing
> -------
> 
> Tested with XMPP.
> 
> 
> Screenshots
> -----------
> 
> Dialog with roomlist
>   http://git.reviewboard.kde.org/r/103825/s/422/
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120130/cf92e528/attachment-0001.html>