Review Request: Baby steps for Chat Plasmoid...

[Lasath Fernando]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103629/
-----------------------------------------------------------

(Updated Jan. 10, 2012, 10:01 a.m.)


Review request for Telepathy and David Edmundson.


Changes
-------

Made changes to address (almost) all of everyone's comments. 

Changed all pointer declarations to fit KDE code style. (KDevelop's find+replace was being useless so I had to use some bash,sed and regexp magic).


Description
-------

Right, I decided that I should have reviewed and/or merge what work I've done so far rather than letting it pile up in its corner into a giant worthless clump. 

To the people that haven't heard (or wasn't at woshibon), this is a chat plasmoid that more or less behaves like facebook and google talk, except it sits in your taskbar :)

And in terms of feedback, at this stage I think design issues should take priority over sane code because the main reason I'm doing this is because I don't want to have to do any massive restructuring later on.

And if things don't make sense, ask me (I didn't comment/document anything well and I'm certainly too sleepy now ;)

PS: All the code is in my scratch repo
http://quickgit.kde.org/?p=clones%2Ftelepathy-text-ui%2Ffernando%2Fqmlplugin.git&a=shortlog&h=refs/heads/qml_plugins2


Diffs (updated)
-----

  CMakeLists.txt d1cc185 
  lib/CMakeLists.txt 5d39a62 
  lib/adium-theme-content-info.h e293732 
  lib/adium-theme-header-info.h 952dc48 
  lib/adium-theme-message-info.h 10c00a2 
  lib/adium-theme-status-info.h 926586a 
  lib/adium-theme-view.h c2fae74 
  lib/adium-theme-view.cpp c834c94 
  lib/chat-search-bar.h 315fd2b 
  lib/chat-search-bar.cpp 15aa5da 
  lib/chat-text-edit.cpp b0476f5 
  lib/chat-widget.h 30afa31 
  lib/chat-widget.cpp 9313c03 
  lib/chat-window-style-manager.h c876ba8 
  lib/chat-window-style-manager.cpp 8604c97 
  lib/chat-window-style.cpp 7b770cf 
  lib/conversation-que-manager.h PRE-CREATION 
  lib/conversation-que-manager.cpp PRE-CREATION 
  lib/conversation-target.h PRE-CREATION 
  lib/conversation-target.cpp PRE-CREATION 
  lib/conversation.h PRE-CREATION 
  lib/conversation.cpp PRE-CREATION 
  lib/conversations-model.h PRE-CREATION 
  lib/conversations-model.cpp PRE-CREATION 
  lib/logmanager.h 4e11086 
  lib/logmanager.cpp 61484af 
  lib/messages-model.h PRE-CREATION 
  lib/messages-model.cpp PRE-CREATION 
  lib/qml-plugins.h PRE-CREATION 
  lib/qml-plugins.cpp PRE-CREATION 
  lib/qmldir PRE-CREATION 
  lib/telepathy-text-observer.h PRE-CREATION 
  lib/telepathy-text-observer.cpp PRE-CREATION 
  plasmoid/CMakeLists.txt PRE-CREATION 
  plasmoid/contents/ui/ChatWidget.qml PRE-CREATION 
  plasmoid/contents/ui/ConversationDelegate.qml PRE-CREATION 
  plasmoid/contents/ui/TextDelegate.qml PRE-CREATION 
  plasmoid/contents/ui/main.qml PRE-CREATION 
  plasmoid/metadata.desktop PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/103629/diff/diff


Testing
-------

Um.. yeah... about that...    :/


Thanks,

Lasath Fernando

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120110/f27bb75d/attachment.html>