<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103629/">http://git.reviewboard.kde.org/r/103629/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Lasath Fernando.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2012, 10:01 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Made changes to address (almost) all of everyone's comments.
Changed all pointer declarations to fit KDE code style. (KDevelop's find+replace was being useless so I had to use some bash,sed and regexp magic).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Right, I decided that I should have reviewed and/or merge what work I've done so far rather than letting it pile up in its corner into a giant worthless clump.
To the people that haven't heard (or wasn't at woshibon), this is a chat plasmoid that more or less behaves like facebook and google talk, except it sits in your taskbar :)
And in terms of feedback, at this stage I think design issues should take priority over sane code because the main reason I'm doing this is because I don't want to have to do any massive restructuring later on.
And if things don't make sense, ask me (I didn't comment/document anything well and I'm certainly too sleepy now ;)
PS: All the code is in my scratch repo
http://quickgit.kde.org/?p=clones%2Ftelepathy-text-ui%2Ffernando%2Fqmlplugin.git&a=shortlog&h=refs/heads/qml_plugins2</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Um.. yeah... about that... :/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d1cc185)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(5d39a62)</span></li>
<li>lib/adium-theme-content-info.h <span style="color: grey">(e293732)</span></li>
<li>lib/adium-theme-header-info.h <span style="color: grey">(952dc48)</span></li>
<li>lib/adium-theme-message-info.h <span style="color: grey">(10c00a2)</span></li>
<li>lib/adium-theme-status-info.h <span style="color: grey">(926586a)</span></li>
<li>lib/adium-theme-view.h <span style="color: grey">(c2fae74)</span></li>
<li>lib/adium-theme-view.cpp <span style="color: grey">(c834c94)</span></li>
<li>lib/chat-search-bar.h <span style="color: grey">(315fd2b)</span></li>
<li>lib/chat-search-bar.cpp <span style="color: grey">(15aa5da)</span></li>
<li>lib/chat-text-edit.cpp <span style="color: grey">(b0476f5)</span></li>
<li>lib/chat-widget.h <span style="color: grey">(30afa31)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(9313c03)</span></li>
<li>lib/chat-window-style-manager.h <span style="color: grey">(c876ba8)</span></li>
<li>lib/chat-window-style-manager.cpp <span style="color: grey">(8604c97)</span></li>
<li>lib/chat-window-style.cpp <span style="color: grey">(7b770cf)</span></li>
<li>lib/conversation-que-manager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/conversation-que-manager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/conversation-target.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/conversation-target.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/conversation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/conversation.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/conversations-model.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/conversations-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/logmanager.h <span style="color: grey">(4e11086)</span></li>
<li>lib/logmanager.cpp <span style="color: grey">(61484af)</span></li>
<li>lib/messages-model.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/messages-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/qml-plugins.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/qml-plugins.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/telepathy-text-observer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/telepathy-text-observer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/contents/ui/ChatWidget.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/contents/ui/ConversationDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/contents/ui/TextDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103629/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>