Review Request: Baby steps for Chat Plasmoid...

[Lasath Fernando]

Sorry for accidentally spamming this 3 times, I haven't used ReviewBoard in
a long time, and it was being evil to me!

On Thu, Jan 5, 2012 at 12:47 AM, Lasath Fernando <kde at lasath.org> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103629/
>   Review request for Telepathy and David Edmundson.
> By Lasath Fernando.
>
> *Updated Jan. 4, 2012, 1:47 p.m.*
> Description
>
> Right, I decided that I should have reviewed and/or merge what work I've done so far rather than letting it pile up in its corner into a giant worthless clump.
>
> To the people that haven't heard (or wasn't at woshibon), this is a chat plasmoid that more or less behaves like facebook and google talk, except it sits in your taskbar :)
>
> And in terms of feedback, at this stage I think design issues should take priority over sane code because the main reason I'm doing this is because I don't want to have to do any massive restructuring later on.
>
> And if things don't make sense, ask me (I didn't comment/document anything well and I'm certainly too sleepy now ;)
>
> PS: All the code is in my scratch repohttp://quickgit.kde.org/?p=clones%2Ftelepathy-text-ui%2Ffernando%2Fqmlplugin.git&a=shortlog&h=refs/heads/qml_plugins2
>
>   Testing
>
> Um.. yeah... about that...    :/
>
>   Diffs
>
>    - CMakeLists.txt (d1cc185)
>    - lib/CMakeLists.txt (5d39a62)
>    - lib/chat-window-style.cpp (7b770cf)
>    - lib/conversation-que-manager.h (PRE-CREATION)
>    - lib/conversation-que-manager.cpp (PRE-CREATION)
>    - lib/conversation-target.h (PRE-CREATION)
>    - lib/conversation-target.cpp (PRE-CREATION)
>    - lib/conversation.h (PRE-CREATION)
>    - lib/conversation.cpp (PRE-CREATION)
>    - lib/conversations-model.h (PRE-CREATION)
>    - lib/conversations-model.cpp (PRE-CREATION)
>    - lib/messages-model.h (PRE-CREATION)
>    - lib/messages-model.cpp (PRE-CREATION)
>    - lib/qml-plugins.h (PRE-CREATION)
>    - lib/qml-plugins.cpp (PRE-CREATION)
>    - lib/qmldir (PRE-CREATION)
>    - lib/telepathy-text-observer.h (PRE-CREATION)
>    - lib/telepathy-text-observer.cpp (PRE-CREATION)
>    - plasmoid/CMakeLists.txt (PRE-CREATION)
>    - plasmoid/contents/ui/ChatWidget.qml (PRE-CREATION)
>    - plasmoid/contents/ui/ConversationDelegate.qml (PRE-CREATION)
>    - plasmoid/contents/ui/TextDelegate.qml (PRE-CREATION)
>    - plasmoid/contents/ui/main.qml (PRE-CREATION)
>    - plasmoid/metadata.desktop (PRE-CREATION)
>
> View Diff <http://git.reviewboard.kde.org/r/103629/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120105/f2d217f3/attachment-0001.html>