Sorry for accidentally spamming this 3 times, I haven't used ReviewBoard in a long time, and it was being evil to me!<br><br><div class="gmail_quote">On Thu, Jan 5, 2012 at 12:47 AM, Lasath Fernando <span dir="ltr"><<a href="mailto:kde@lasath.org">kde@lasath.org</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">



 <div>
  <div style="font-family:Verdana,Arial,Helvetica,Sans-Serif">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid">
    <tbody><tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103629/" target="_blank">http://git.reviewboard.kde.org/r/103629/</a>
     </td>
    </tr>
   </tbody></table>
   <br>


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image:url('');background-repeat:repeat-x;border:1px black solid">
 <tbody><tr>
  <td>

<div>Review request for Telepathy and David Edmundson.</div>
<div>By Lasath Fernando.</div>


<p style="color:grey"><i>Updated Jan. 4, 2012, 1:47 p.m.</i></p>






<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
 <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Right, I decided that I should have reviewed and/or merge what work I've done so far rather than letting it pile up in its corner into a giant worthless clump. 

To the people that haven't heard (or wasn't at woshibon), this is a chat plasmoid that more or less behaves like facebook and google talk, except it sits in your taskbar :)

And in terms of feedback, at this stage I think design issues should take priority over sane code because the main reason I'm doing this is because I don't want to have to do any massive restructuring later on.

And if things don't make sense, ask me (I didn't comment/document anything well and I'm certainly too sleepy now ;)

PS: All the code is in my scratch repo
<a href="http://quickgit.kde.org/?p=clones%2Ftelepathy-text-ui%2Ffernando%2Fqmlplugin.git&a=shortlog&h=refs/heads/qml_plugins2" target="_blank">http://quickgit.kde.org/?p=clones%2Ftelepathy-text-ui%2Ffernando%2Fqmlplugin.git&a=shortlog&h=refs/heads/qml_plugins2</a></pre>


  </td>
 </tr>
</tbody></table>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
 <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Um.. yeah... about that...    :/</pre>
  </td>
 </tr>
</tbody></table>




<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">

 <li>CMakeLists.txt <span style="color:grey">(d1cc185)</span></li>

 <li>lib/CMakeLists.txt <span style="color:grey">(5d39a62)</span></li>

 <li>lib/chat-window-style.cpp <span style="color:grey">(7b770cf)</span></li>

 <li>lib/conversation-que-manager.h <span style="color:grey">(PRE-CREATION)</span></li>

 <li>lib/conversation-que-manager.cpp <span style="color:grey">(PRE-CREATION)</span></li>

 <li>lib/conversation-target.h <span style="color:grey">(PRE-CREATION)</span></li>

 <li>lib/conversation-target.cpp <span style="color:grey">(PRE-CREATION)</span></li>

 <li>lib/conversation.h <span style="color:grey">(PRE-CREATION)</span></li>

 <li>lib/conversation.cpp <span style="color:grey">(PRE-CREATION)</span></li>

 <li>lib/conversations-model.h <span style="color:grey">(PRE-CREATION)</span></li>

 <li>lib/conversations-model.cpp <span style="color:grey">(PRE-CREATION)</span></li>

 <li>lib/messages-model.h <span style="color:grey">(PRE-CREATION)</span></li>

 <li>lib/messages-model.cpp <span style="color:grey">(PRE-CREATION)</span></li>

 <li>lib/qml-plugins.h <span style="color:grey">(PRE-CREATION)</span></li>

 <li>lib/qml-plugins.cpp <span style="color:grey">(PRE-CREATION)</span></li>

 <li>lib/qmldir <span style="color:grey">(PRE-CREATION)</span></li>

 <li>lib/telepathy-text-observer.h <span style="color:grey">(PRE-CREATION)</span></li>

 <li>lib/telepathy-text-observer.cpp <span style="color:grey">(PRE-CREATION)</span></li>

 <li>plasmoid/CMakeLists.txt <span style="color:grey">(PRE-CREATION)</span></li>

 <li>plasmoid/contents/ui/ChatWidget.qml <span style="color:grey">(PRE-CREATION)</span></li>

 <li>plasmoid/contents/ui/ConversationDelegate.qml <span style="color:grey">(PRE-CREATION)</span></li>

 <li>plasmoid/contents/ui/TextDelegate.qml <span style="color:grey">(PRE-CREATION)</span></li>

 <li>plasmoid/contents/ui/main.qml <span style="color:grey">(PRE-CREATION)</span></li>

 <li>plasmoid/metadata.desktop <span style="color:grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103629/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>




  </td>
 </tr>
</tbody></table>




  </div>
 </div>


</div></div></blockquote></div><br>