Review Request: double check connection manager for accounts kcm

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103592/#review9414
-----------------------------------------------------------


I'd ideally like it if we could share the same code that's in ProfileListModel::populateList(). Duplication is bad. 

Maybe we add a method in ProfileListModel that returns profileItem for a given ID and then we have one instance of ProfileListModel in the wizard which is passed as a parameter to both the pages (simple profile select and full profile select). 


src/KCMTelepathyAccounts/simple-profile-select-widget.cpp
<http://git.reviewboard.kde.org/r/103592/#comment7749>

    This isn't needed.
    
    An object will have the default constructor called on it (i.e QString()).
    
    It's needed for the others because they're pointers.
    
    


- David Edmundson


On Jan. 1, 2012, 7:18 p.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103592/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2012, 7:18 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> When no connection manager installed, the KCM would show broken dialogs for jabber, google-talk and facebook chat because of the shipped profile files.
> 
> The patch makes the kcm module now check if the connection manager for the required profile exists.
> 
> 
> Diffs
> -----
> 
>   src/KCMTelepathyAccounts/simple-profile-select-widget.h 88caa0a85d5bb5c22c975f712dc452391c158211 
>   src/KCMTelepathyAccounts/simple-profile-select-widget.cpp 88fef12c38b7724cc364a3dbc78a42fa83c2919a 
> 
> Diff: http://git.reviewboard.kde.org/r/103592/diff/diff
> 
> 
> Testing
> -------
> 
> clicked all buttons with no connection manager at all installed => installation required
> clicked all buttons with the required connection managers installed => properties dialog
> 
> 
> Thanks,
> 
> Florian Reinhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120101/480ea285/attachment-0001.html>