Review Request: double check connection manager for accounts kcm

Florian Reinhard florian.reinhard at googlemail.com
Sun Jan 1 19:18:22 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103592/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

When no connection manager installed, the KCM would show broken dialogs for jabber, google-talk and facebook chat because of the shipped profile files.

The patch makes the kcm module now check if the connection manager for the required profile exists.


Diffs
-----

  src/KCMTelepathyAccounts/simple-profile-select-widget.h 88caa0a85d5bb5c22c975f712dc452391c158211 
  src/KCMTelepathyAccounts/simple-profile-select-widget.cpp 88fef12c38b7724cc364a3dbc78a42fa83c2919a 

Diff: http://git.reviewboard.kde.org/r/103592/diff/diff


Testing
-------

clicked all buttons with no connection manager at all installed => installation required
clicked all buttons with the required connection managers installed => properties dialog


Thanks,

Florian Reinhard

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120101/fb8187d0/attachment.html>


More information about the KDE-Telepathy mailing list