Review Request: Do not ship headers which are not used elsewhere in the project

[Rohan Garg]

> On Feb. 7, 2012, 11:40 a.m., David Edmundson wrote:
> > I still don't understand the point of doing this.
> > 
> > What if I want to use the text-ui libraries in another project later? I intend to make some collaborative program at some point this release cycle, I intend to embed a chat. This lib was designed to make that easy to do.
> 
> Rohan Garg wrote:
>     Hmm, I was not aware that you intend to write such a program later on in this cycle. But since none of the programs are currently using the libs, hence it  does not make sense to install them. I'd rather like this patch reverted when a app that does use the headers comes into being :)
> 
> David Edmundson wrote:
>     It all sounds a somewhat pointless exercise to me. 
>     
>     I'm sure the two of us could argue for hours, but I can't really be bothered.
>     Lets have George K or Martin K comment on this, whatever they decide is final.
> 
> Rohan Garg wrote:
>     :D
>     Works for me.
> 
> Martin Klapetek wrote:
>     I always say "better to have and not need than not have and need". In spite of this and also the fact that we're about to use these headers, it seems useless to remove it and add it back in two weeks - more work for everyone.
>     
>     I hate wasted effort, some ideas are just better to discuss/ask first :/

Hi Martin
I actually did post to the list but no one replied, so I just posted to reviewboard instead. I'll mark the request as closed.


- Rohan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103883/#review10390
-----------------------------------------------------------


On Feb. 7, 2012, 11:32 a.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103883/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2012, 11:32 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Do not ship headers which are not used elsewhere in the project, these are useless and consume disk space ( even though its in KB's ).
> 
> 
> Diffs
> -----
> 
>   lib/CMakeLists.txt 31dadd2 
> 
> Diff: http://git.reviewboard.kde.org/r/103883/diff/diff
> 
> 
> Testing
> -------
> 
> Everything else compiles and works without the headers installed.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120207/8c31e821/attachment.html>