<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103883/">http://git.reviewboard.kde.org/r/103883/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 7th, 2012, 11:40 a.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I still don't understand the point of doing this.
What if I want to use the text-ui libraries in another project later? I intend to make some collaborative program at some point this release cycle, I intend to embed a chat. This lib was designed to make that easy to do.</pre>
</blockquote>
<p>On February 7th, 2012, 11:58 a.m., <b>Rohan Garg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, I was not aware that you intend to write such a program later on in this cycle. But since none of the programs are currently using the libs, hence it does not make sense to install them. I'd rather like this patch reverted when a app that does use the headers comes into being :)</pre>
</blockquote>
<p>On February 7th, 2012, 12:59 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It all sounds a somewhat pointless exercise to me.
I'm sure the two of us could argue for hours, but I can't really be bothered.
Lets have George K or Martin K comment on this, whatever they decide is final.</pre>
</blockquote>
<p>On February 7th, 2012, 1 p.m., <b>Rohan Garg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">:D
Works for me.</pre>
</blockquote>
<p>On February 7th, 2012, 4:33 p.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I always say "better to have and not need than not have and need". In spite of this and also the fact that we're about to use these headers, it seems useless to remove it and add it back in two weeks - more work for everyone.
I hate wasted effort, some ideas are just better to discuss/ask first :/</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Martin
I actually did post to the list but no one replied, so I just posted to reviewboard instead. I'll mark the request as closed.</pre>
<br />
<p>- Rohan</p>
<br />
<p>On February 7th, 2012, 11:32 a.m., Rohan Garg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Rohan Garg.</div>
<p style="color: grey;"><i>Updated Feb. 7, 2012, 11:32 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do not ship headers which are not used elsewhere in the project, these are useless and consume disk space ( even though its in KB's ).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Everything else compiles and works without the headers installed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/CMakeLists.txt <span style="color: grey">(31dadd2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103883/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>