Review Request: Do not ship headers which are not used elsewhere in the project

[Rohan Garg]

> On Feb. 7, 2012, 11:40 a.m., David Edmundson wrote:
> > I still don't understand the point of doing this.
> > 
> > What if I want to use the text-ui libraries in another project later? I intend to make some collaborative program at some point this release cycle, I intend to embed a chat. This lib was designed to make that easy to do.

Hmm, I was not aware that you intend to write such a program later on in this cycle. But since none of the programs are currently using the libs, hence it  does not make sense to install them. I'd rather like this patch reverted when a app that does use the headers comes into being :)


- Rohan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103883/#review10390
-----------------------------------------------------------


On Feb. 7, 2012, 11:32 a.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103883/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2012, 11:32 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Do not ship headers which are not used elsewhere in the project, these are useless and consume disk space ( even though its in KB's ).
> 
> 
> Diffs
> -----
> 
>   lib/CMakeLists.txt 31dadd2 
> 
> Diff: http://git.reviewboard.kde.org/r/103883/diff/diff
> 
> 
> Testing
> -------
> 
> Everything else compiles and works without the headers installed.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120207/cc7d6e20/attachment.html>