Review Request: Do not ship headers which are not used elsewhere in the project
David Edmundson
kde at davidedmundson.co.uk
Tue Feb 7 11:40:23 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103883/#review10390
-----------------------------------------------------------
I still don't understand the point of doing this.
What if I want to use the text-ui libraries in another project later? I intend to make some collaborative program at some point this release cycle, I intend to embed a chat. This lib was designed to make that easy to do.
- David Edmundson
On Feb. 7, 2012, 11:32 a.m., Rohan Garg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103883/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2012, 11:32 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Do not ship headers which are not used elsewhere in the project, these are useless and consume disk space ( even though its in KB's ).
>
>
> Diffs
> -----
>
> lib/CMakeLists.txt 31dadd2
>
> Diff: http://git.reviewboard.kde.org/r/103883/diff/diff
>
>
> Testing
> -------
>
> Everything else compiles and works without the headers installed.
>
>
> Thanks,
>
> Rohan Garg
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120207/d6c8eec3/attachment.html>
More information about the KDE-Telepathy
mailing list