Review Request: check in AddAccountAssistant for installed connection managers and optional install them

[Florian Reinhard]

> On Dec. 29, 2012, 11:46 a.m., David Edmundson wrote:
> > src/KCMTelepathyAccounts/simple-profile-select-widget.cpp, line 147
> > <http://git.reviewboard.kde.org/r/107995/diff/2/?file=102522#file102522line147>
> >
> >     I think maybe we should go with:
> >     "Your setup misses some optional telepathy plugin"
> >     
> >     (with the word optional added)
> >     
> >     Or maybe we should explain what these plugins do "In order to enable all possible accounts, further plugins must be installed".
> >     
> >     Discuss.

"Your setup misses some optional telepathy plugin" yes, that's better.

"In order to enable all possible accounts, further plugins must be installed"
I'm not sure if this is right, because were about to add an account for a protocol that we can't use. I think this would be ok for .

To be consistent with the line above the KMessageWidget "Step 1: Select an Instant Messaging Network." i'd suggest
"In order to enable all possible instant messaging networks, further plugins must be installed" or
"In order to enable all supported instant messaging networks, further plugins must be installed"

Besides the words:
The button is called "Install", no matter what it does. If packageinstallation is disabled you just get a message box. Maybe the button should be called something else with a (i) icon?


- Florian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107995/#review24156
-----------------------------------------------------------


On Dec. 29, 2012, 12:04 a.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107995/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2012, 12:04 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Check in SimpleProfileSelectWidget if required connection managers are installed
>     
> * new cmake option -DPACKAGE_INSTALLATION=[apt,packagekit]
> * default: no package installation enabled just promt a message
> * on the first page of AddAccountAssistant profiles with no CM installed will be disabled
> 
> 
> Diffs
> -----
> 
>   src/KCMTelepathyAccounts/CMakeLists.txt e19f3accf465f852012d251f69bbfa2ff372bb7f 
>   src/KCMTelepathyAccounts/package-install-action.h PRE-CREATION 
>   src/KCMTelepathyAccounts/package-install-action.cpp PRE-CREATION 
>   src/KCMTelepathyAccounts/profile-list-model.h 8b313d19765b63071408047b5d183ecc419500de 
>   src/KCMTelepathyAccounts/profile-list-model.cpp 12752928f377552a323a502557d2717819c257de 
>   src/KCMTelepathyAccounts/simple-profile-select-widget.h 52eede1c4d5b7a39143b71c19f33dcb965827bf9 
>   src/KCMTelepathyAccounts/simple-profile-select-widget.cpp 5f9a516e74a17c8cf86a5f5382d5071baff1c8a8 
>   src/KCMTelepathyAccounts/simple-profile-select-widget.ui 5ad8e79a7bd4fd6d52dac61cbd88becb0cd569ae 
> 
> Diff: http://git.reviewboard.kde.org/r/107995/diff/
> 
> 
> Testing
> -------
> 
> * remove telepathy-haze
> * start the kcm
> * result see screenshot
> 
> 
> Screenshots
> -----------
> 
> telepathy-haze not installed
>   http://git.reviewboard.kde.org/r/107995/s/937/
> 
> 
> Thanks,
> 
> Florian Reinhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121230/6f1fc7c4/attachment.html>