<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107995/">http://git.reviewboard.kde.org/r/107995/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 29th, 2012, 11:46 a.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107995/diff/2/?file=102522#file102522line147" style="color: black; font-weight: bold; text-decoration: underline;">src/KCMTelepathyAccounts/simple-profile-select-widget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void SimpleProfileSelectWidget::onConnectionManagerNamesFetched()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">141</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">ui</span><span class="o">-></span><span class="n">messageWidget</span><span class="o">-></span><span class="n">setText</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">"Your setup misses some telepathy plugins."</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think maybe we should go with:
"Your setup misses some optional telepathy plugin"
(with the word optional added)
Or maybe we should explain what these plugins do "In order to enable all possible accounts, further plugins must be installed".
Discuss.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"Your setup misses some optional telepathy plugin" yes, that's better.
"In order to enable all possible accounts, further plugins must be installed"
I'm not sure if this is right, because were about to add an account for a protocol that we can't use. I think this would be ok for .
To be consistent with the line above the KMessageWidget "Step 1: Select an Instant Messaging Network." i'd suggest
"In order to enable all possible instant messaging networks, further plugins must be installed" or
"In order to enable all supported instant messaging networks, further plugins must be installed"
Besides the words:
The button is called "Install", no matter what it does. If packageinstallation is disabled you just get a message box. Maybe the button should be called something else with a (i) icon?</pre>
<br />
<p>- Florian</p>
<br />
<p>On December 29th, 2012, 12:04 a.m., Florian Reinhard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Florian Reinhard.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2012, 12:04 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Check in SimpleProfileSelectWidget if required connection managers are installed
* new cmake option -DPACKAGE_INSTALLATION=[apt,packagekit]
* default: no package installation enabled just promt a message
* on the first page of AddAccountAssistant profiles with no CM installed will be disabled
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* remove telepathy-haze
* start the kcm
* result see screenshot
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/KCMTelepathyAccounts/CMakeLists.txt <span style="color: grey">(e19f3accf465f852012d251f69bbfa2ff372bb7f)</span></li>
<li>src/KCMTelepathyAccounts/package-install-action.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/package-install-action.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/profile-list-model.h <span style="color: grey">(8b313d19765b63071408047b5d183ecc419500de)</span></li>
<li>src/KCMTelepathyAccounts/profile-list-model.cpp <span style="color: grey">(12752928f377552a323a502557d2717819c257de)</span></li>
<li>src/KCMTelepathyAccounts/simple-profile-select-widget.h <span style="color: grey">(52eede1c4d5b7a39143b71c19f33dcb965827bf9)</span></li>
<li>src/KCMTelepathyAccounts/simple-profile-select-widget.cpp <span style="color: grey">(5f9a516e74a17c8cf86a5f5382d5071baff1c8a8)</span></li>
<li>src/KCMTelepathyAccounts/simple-profile-select-widget.ui <span style="color: grey">(5ad8e79a7bd4fd6d52dac61cbd88becb0cd569ae)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107995/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107995/s/937/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/28/ktp-kcm-missing-haze_400x100.png" style="border: 1px black solid;" alt="telepathy-haze not installed" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>