Review Request: Store a QPersistentModelIndex not a ModelIndex

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107652/#review23233
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Klapetek


On Dec. 9, 2012, 9:50 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107652/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2012, 9:50 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Store a QPersistentModelIndex not a ModelIndex
> 
> When a model index is stored outside the scope of a function the persistent version should _always_ be used.
> In practice in this case it's probably safe, but it is still wrong.
> 
> Remove usages of GroupsModelItem in ContextMenu
> 
> 
> Diffs
> -----
> 
>   context-menu.h b862550d66951cbf64e0aeea38c0b45960b6021e 
>   context-menu.cpp 16bf0cd646a3aaa5242403858a4c76302ff20ce7 
> 
> Diff: http://git.reviewboard.kde.org/r/107652/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121209/c841213f/attachment.html>