Review Request: Store a QPersistentModelIndex not a ModelIndex
David Edmundson
david at davidedmundson.co.uk
Sun Dec 9 21:50:27 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107652/
-----------------------------------------------------------
Review request for Telepathy.
Description
-------
Store a QPersistentModelIndex not a ModelIndex
When a model index is stored outside the scope of a function the persistent version should _always_ be used.
In practice in this case it's probably safe, but it is still wrong.
Remove usages of GroupsModelItem in ContextMenu
Diffs
-----
context-menu.h b862550d66951cbf64e0aeea38c0b45960b6021e
context-menu.cpp 16bf0cd646a3aaa5242403858a4c76302ff20ce7
Diff: http://git.reviewboard.kde.org/r/107652/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121209/c1fbc55d/attachment.html>
More information about the KDE-Telepathy
mailing list